[No QA] Replace ActiveElementRoleProvider context with useSyncExternalStore#83805
Draft
adhorodyski wants to merge 2 commits intoExpensify:mainfrom
Draft
[No QA] Replace ActiveElementRoleProvider context with useSyncExternalStore#83805adhorodyski wants to merge 2 commits intoExpensify:mainfrom
adhorodyski wants to merge 2 commits intoExpensify:mainfrom
Conversation
Eliminates the context provider from the component tree and replaces it with a lightweight useSyncExternalStore hook. React 18 batches the focusout+focusin events into a single render, removing the intermediate null state and ~40-60 wasted component re-renders per focus transition. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
ActiveElementRoleProviderused React context to propagate the ARIA role of the currently focused DOM element. This meant every context consumer re-rendered on every focus/blur event — roughly 40–60 components per focus transition.This PR removes the provider entirely and rewrites
useActiveElementRoleto useuseSyncExternalStorewith a module-level event listener. Each consumer subscribes independently to a single shared store, so React 18 can batch thefocusout+focusinevents that happen on a focus transition into one render per subscriber instead of cascading through the full context tree.Changes:
src/components/ActiveElementRoleProvider/(provider, native stub, types — ~70 lines)ActiveElementRoleProviderfromComposeProvidersinsrc/App.tsxsrc/hooks/useActiveElementRole/index.tsto useuseSyncExternalStoresrc/hooks/useActiveElementRole/index.native.tsreturningnull(native has no DOM focus events)Fixed Issues
$
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari